Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AlterIndex completion #935

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Add AlterIndex completion #935

merged 1 commit into from
Oct 27, 2023

Conversation

jachro
Copy link
Contributor

@jachro jachro commented Aug 2, 2023

This tiny PR follows the suggestion from the SkunkException I received after issuing an ALTER INDEX command.

I tried to follow the guidelines for running the tests locally but I hit one issue:

==> X tests.StartupTest.invalid port 0.01s scala.scalajs.js.JavaScriptException: AggregateError
    at <jscode>.internalConnectMultiple(node:net:1111)
    at <jscode>.afterConnectMultiple(node:net:1663)
    at delay @ <jscode>.{anonymous}()(/Users/chrobasi/sdsc/code/skunk/modules/tests/js/target/scala-2.13/tests-test-fastopt/main.js:93975)
    at as @ <jscode>.{anonymous}()(/Users/chrobasi/sdsc/code/skunk/modules/tests/js/target/scala-2.13/tests-test-fastopt/main.js:246615)
    at delay @ fs2.io.internal.facade.events.EventEmitter$ops$.registerOneTimeListener$extension(/Users/chrobasi/sdsc/code/skunk/modules/tests/js/target/scala-2.13/tests-test-fastopt/main.js:7947)
    at productL @ <jscode>.{anonymous}()(/Users/chrobasi/sdsc/code/skunk/modules/tests/js/target/scala-2.13/tests-test-fastopt/main.js:93980)
    at flatMap @ <jscode>.{anonymous}()(/Users/chrobasi/sdsc/code/skunk/modules/tests/js/target/scala-2.13/tests-test-fastopt/main.js:90305)
    at async @ <jscode>.{anonymous}()(/Users/chrobasi/sdsc/code/skunk/modules/tests/js/target/scala-2.13/tests-test-fastopt/main.js:93964)
    at allocatedCase @ <jscode>.{anonymous}()(/Users/chrobasi/sdsc/code/skunk/modules/tests/js/target/scala-2.13/tests-test-fastopt/main.js:46843)
    at refOf @ <jscode>.{anonymous}()(/Users/chrobasi/sdsc/code/skunk/modules/tests/js/target/scala-2.13/tests-test-fastopt/main.js:43986)
    at apply @ skunk.net.protocol.Exchange$.apply(/Users/chrobasi/sdsc/code/skunk/modules/tests/js/target/scala-2.13/tests-test-fastopt/main.js:41801)
    at allocatedCase @ <jscode>.{anonymous}()(/Users/chrobasi/sdsc/code/skunk/modules/tests/js/target/scala-2.13/tests-test-fastopt/main.js:46843)
    at refOf @ <jscode>.{anonymous}()(/Users/chrobasi/sdsc/code/skunk/modules/tests/js/target/scala-2.13/tests-test-fastopt/main.js:43986)
    at allocatedCase @ <jscode>.{anonymous}()(/Users/chrobasi/sdsc/code/skunk/modules/tests/js/target/scala-2.13/tests-test-fastopt/main.js:46843)
    at onError @ <jscode>.{anonymous}()(/Users/chrobasi/sdsc/code/skunk/modules/tests/js/target/scala-2.13/tests-test-fastopt/main.js:42665)
    at make @ skunk.util.Pool$.ofF(/Users/chrobasi/sdsc/code/skunk/modules/tests/js/target/scala-2.13/tests-test-fastopt/main.js:42801)
    at make @ skunk.util.Pool$.ofF(/Users/chrobasi/sdsc/code/skunk/modules/tests/js/target/scala-2.13/tests-test-fastopt/main.js:42801)

Unfortunately, I'm not sure how to fix it but I've got a feeling it's probably not related to my change.

@armanbilge
Copy link
Member

I tried to follow the guidelines for running the tests locally but I hit one issue:

What version of Node.js do you have installed? i.e. node --version.

@jachro
Copy link
Contributor Author

jachro commented Aug 2, 2023

I tried to follow the guidelines for running the tests locally but I hit one issue:

What version of Node.js do you have installed? i.e. node --version.

I've got v20.5.0

@armanbilge
Copy link
Member

Thanks, I opened a PR to fix it.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81c936c) 84.32% compared to head (5eec2e9) 84.33%.

Additional details and impacted files
@@              Coverage Diff              @@
##           series/0.6.x     #935   +/-   ##
=============================================
  Coverage         84.32%   84.33%           
=============================================
  Files               126      126           
  Lines              1735     1736    +1     
  Branches            170      161    -9     
=============================================
+ Hits               1463     1464    +1     
  Misses              272      272           
Files Coverage Δ
...s/core/shared/src/main/scala/data/Completion.scala 100.00% <ø> (ø)
...d/src/main/scala/net/message/CommandComplete.scala 92.30% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@armanbilge
Copy link
Member

This looks like a good candidate to re-target for series/0.6.x branch.

@jachro
Copy link
Contributor Author

jachro commented Aug 16, 2023

This looks like a good candidate to re-target for series/0.6.x branch.

I know it's a tiny change but it's still a pleasure to hear that.

@mpilquist mpilquist changed the base branch from main to series/0.6.x October 10, 2023 11:42
@mpilquist mpilquist changed the base branch from series/0.6.x to main October 10, 2023 11:42
@armanbilge armanbilge changed the base branch from main to series/0.6.x October 20, 2023 13:11
@mpilquist mpilquist merged commit 314a319 into typelevel:series/0.6.x Oct 27, 2023
14 checks passed
@jachro jachro deleted the addAlterIndexCompletion branch October 30, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants