-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AlterIndex completion #935
Add AlterIndex completion #935
Conversation
What version of Node.js do you have installed? i.e. |
I've got |
Thanks, I opened a PR to fix it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## series/0.6.x #935 +/- ##
=============================================
Coverage 84.32% 84.33%
=============================================
Files 126 126
Lines 1735 1736 +1
Branches 170 161 -9
=============================================
+ Hits 1463 1464 +1
Misses 272 272
☔ View full report in Codecov by Sentry. |
This looks like a good candidate to re-target for |
I know it's a tiny change but it's still a pleasure to hear that. |
This tiny PR follows the suggestion from the
SkunkException
I received after issuing anALTER INDEX
command.I tried to follow the guidelines for running the tests locally but I hit one issue:
Unfortunately, I'm not sure how to fix it but I've got a feeling it's probably not related to my change.