Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otel4s-0.2.1 #857

Merged
merged 16 commits into from
May 8, 2023
Merged

otel4s-0.2.1 #857

merged 16 commits into from
May 8, 2023

Conversation

rossabaker
Copy link
Member

Continuation of rossabaker#2. Replaces Natchez tracing with otel4s.

@rossabaker
Copy link
Member Author

Docs don't compile yet. There are a few compilation warnings that I don't think I introduced. Just wanted to get it out of the shadows.

@rossabaker
Copy link
Member Author

docker-compose is trying to make directories in my root folder, so I can't easily run mdoc. There's a lot of tedious noop work to be done, and I think otel4s should adopt Natchez's approach to that.

otel4s isn't published for 2.12. I haven't kept up with Skunk's plans on that front.

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Merging #857 (cbeba3c) into main (be9e8a6) will not change coverage.
The diff coverage is 89.65%.

@@           Coverage Diff           @@
##             main     #857   +/-   ##
=======================================
  Coverage   83.88%   83.88%           
=======================================
  Files         125      125           
  Lines        1756     1756           
  Branches      159      213   +54     
=======================================
  Hits         1473     1473           
  Misses        283      283           
Impacted Files Coverage Δ
...ules/core/shared/src/main/scala/net/Protocol.scala 82.35% <ø> (ø)
...core/shared/src/main/scala/net/protocol/Bind.scala 100.00% <ø> (ø)
...ore/shared/src/main/scala/net/protocol/Parse.scala 91.66% <ø> (ø)
...e/shared/src/main/scala/net/protocol/Prepare.scala 100.00% <ø> (ø)
...ared/src/main/scala/exception/SkunkException.scala 72.50% <68.75%> (+0.70%) ⬆️
modules/core/shared/src/main/scala/util/Pool.scala 95.65% <83.33%> (ø)
.../src/main/scala/net/protocol/StartupPlatform.scala 94.11% <100.00%> (ø)
modules/core/shared/src/main/scala/Session.scala 57.30% <100.00%> (ø)
.../main/scala/exception/PostgresErrorException.scala 97.05% <100.00%> (+0.08%) ⬆️
...ore/shared/src/main/scala/net/protocol/Close.scala 100.00% <100.00%> (ø)
... and 6 more

@mpilquist
Copy link
Member

Re: 2.12, let's drop it for Skunk 1.0.

@armanbilge armanbilge mentioned this pull request May 1, 2023
@mpilquist
Copy link
Member

I pushed a few commits that should get build working (or at least closer).

@mpilquist
Copy link
Member

@rossabaker Any objections to merging this one now that we have a separate branch for 0.6.x releases?

@rossabaker
Copy link
Member Author

Sounds good to me. There are a couple improvements I'd like to make to otel4s from this experience, but better to get the big one merged and refine later.

@mpilquist mpilquist marked this pull request as ready for review May 8, 2023 14:34
@mpilquist mpilquist merged commit 2a9b469 into typelevel:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants