Update to munit 1.0.0-M6 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Jun 25, 2022
Comment on lines
99
to
100
| case _: InvocationTargetException | _: ExceptionInInitializerError | | ||
| _: UndeclaredThrowableException | _: ExecutionException if x.getCause != null => | ||
| // should also include InvocationTargetException and UndeclaredThrowableException, but not on SJS | ||
| case _: ExceptionInInitializerError | _: ExecutionException if x.getCause != null => |
There was a problem hiding this comment.
These exceptions don't link for Scala.js. I'm not sure how much they matter. If anyone JVM-side complains we can always split this code cross-platform or something /shrug
There was a problem hiding this comment.
Note the PR that fixed this was observing an ExecutionException
armanbilge
commented
Jul 16, 2022
Comment on lines
-96
to
-103
| // https://github.com/scalameta/munit/blob/68c2d13868baec9a77384f11f97505ecc0ce3eba/munit/shared/src/main/scala/munit/MUnitRunner.scala#L318-L326 | ||
| @tailrec | ||
| private def rootCause(x: Throwable): Throwable = x match { | ||
| case _: InvocationTargetException | _: ExceptionInInitializerError | | ||
| _: UndeclaredThrowableException | _: ExecutionException if x.getCause != null => | ||
| rootCause(x.getCause) | ||
| case _ => x | ||
| } |
There was a problem hiding this comment.
This is now a public method in MUnit.
valencik
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yoloing, let's see what CI says :)