Add munit cats-effect integration #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpilquist
approved these changes
Aug 9, 2020
| ): FunFixture[T] = | ||
| fromResource( | ||
| resource, | ||
| (_, _) => IO.pure(()), |
There was a problem hiding this comment.
Note you can do IO.unit instead of IO.pure(())
| abstract class CatsEffectSuite extends FunSuite { | ||
|
|
||
| def munitContextShift: ContextShift[IO] = | ||
| IO.contextShift(munitExecutionContext) |
There was a problem hiding this comment.
munitExecutionContext is parasitic -- I've seen issues when running async tests as a result (the parZip tests in FS2 specifically, where the parasitic nature breaks concurrency, which the test relies on).
I guess the solution can be telling folks to override munitExecutionContext if they need true concurrency.
There was a problem hiding this comment.
That would be a good comment/remark to add to the documentation for sure!
|
I have nothing to add since I know very little about fs2 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved and improved the logic from scalameta/munit#134
Let me know what you think :)