-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JS macrotask executor for CE 2 #194
Conversation
Hmm, why not use the |
@armanbilge because it brings new dependency and needs full-fledged testing. And yeah, I'm not an actual ScalaJS user. |
Damn it, Scala 3 doesn't contain |
FWIW the |
@armanbilge so, I've followed your (and compiler's one) advice to use |
implicit def munitContextShift: ContextShift[IO] = | ||
IO.contextShift(ExecutionContext.global) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use munitExecutionContext
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was intentional #65
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, munit uses parisitic EC ?? thanks for the pointer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM 👍
Even if we don't use fatal warnings, it, all the same, strikes the eye on every compile, CI run.