Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of Cross-Platform Support for ResourceSuiteLocalFixture #172

Closed
ChristopherDavenport opened this issue Dec 24, 2021 · 2 comments · Fixed by #223
Closed

Lack of Cross-Platform Support for ResourceSuiteLocalFixture #172

ChristopherDavenport opened this issue Dec 24, 2021 · 2 comments · Fixed by #223

Comments

@ChristopherDavenport
Copy link
Member

For the same reason this is useful on the jvm, it would be useful when running for js.

Currently options are to have a build specific test and spin up resources on each test on js, or spin up resources on each test on both jvm and js, while ideally it would be nice to use this feature in cross-compatible code.

@armanbilge
Copy link
Member

Try this: #104?

@armanbilge
Copy link
Member

The underlying issue is that munit currently doesn't support async suite-local fixtures. The JVM implementation relies on blocking which we don't have on JS. The PR above introduces a workaround, however that is unsafe. This can be fixed after munit 1.0 is released, see #147.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants