-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with upcoming munit v1 #147
Comments
I think we should support munit 1 + ce2 as there are a lot of projects (fs2 2.5.x included) that depend on munit and we shouldn't strand them on a 0.x release. |
@mpilquist 6 months later, do you still feel the same? We will shortly be removing http4s 0.22.x from Steward. Meanwhile, I discovered the other day that fs2 2.5.x CI probably hasn't worked for months. @valencik had the excellent suggestion to look at download stats. Here they are for the CE2 and CE3 versions, don't be fooled by the colors! :) The majority of the CE2 users have not updated since 1.0.0, which suggests those projects are not actively maintained. Meanwhile, the majority of the CE3 users are on the latest release. |
No strong opinions here. |
FYI https://scalameta.org/munit/docs/fixtures.html#asynchronous-fixtures-with-custom-effect-type Edit: I had a look if the new functionality allows me to migrate away from |
Another nail in the coffin. |
Opening the issue to kick things off, munit v1 is still in the milestone stage.
https://github.com/scalameta/munit/releases/tag/v1.0.0-M1
The most notable changes (so far) are that it now supports async suite-local
Fixture
s 🎉 . Much gratitude to @danicheg for PRing this 👏My biggest question is: for how long do we still intend to support both CE2 and CE3? Since we are bumping version numbers anyway, I'd be happy to use this opportunity to dump CE2 and the acrobatics this repo uses to share code between them.
The text was updated successfully, but these errors were encountered: