Performance improvements in Chunk#toArray #979
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #977.
Includes a series of optimizations:
Chunk#toArray
now simply uses a while loop instead of using the segment machinery to access each element (not sure why it ever did what it was doing...)toArray
is overridden on each array backed chunk subtype using.slice
operationtoByteBuffer
was added toChunk.Bytes
allowing a zero-copy view of the underlying array@fiadliel could you take a look at this?