fix for npe in segment's flatmap #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More eager version of a scan: emits values immediately upon calculation
|
PS: no idea why gh picked up changes in |
|
Thanks for finding this and fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I detected this issue when I was running old code that I ported from 0.9 to 0.10. I discovered that there is the real possibility of a null pointer exception in the
flatMapmethod ofSegment, see the backtrace here: http://lpaste.net/358781This problem is related to #922 where a null pointer exception was discovered and fixed in the
flatMapAccumulatemethod, also ofSegment.I tested the fix with my code, and the problem has disappeared.
Take this fix with a grain of salt. It might be incorrect. I can't say I understand the segment stepper code very well. I followed the types and used common sense to create this solution.