Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove walkEager optimization #3394

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Remove walkEager optimization #3394

merged 4 commits into from
Mar 1, 2024

Conversation

mpilquist
Copy link
Member

Drops the specialized walkEager optimization as walkJustInTime is just as efficient in the case where chunkSize = Int.MaxValue. This lets us get rid of the specialized platform traits (AsyncFilesPlatform).

Merge after #3390

@mpilquist mpilquist requested a review from armanbilge February 23, 2024 12:57
SystemFw
SystemFw approved these changes Feb 25, 2024
View reviewed changes
Copy link
Collaborator

@SystemFw SystemFw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mpilquist mpilquist merged commit 52b9e5d into typelevel:main Mar 1, 2024
15 checks passed
@mpilquist mpilquist deleted the topic/walk-drop-eager-optimization branch March 1, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemFw SystemFw SystemFw approved these changes

@armanbilge armanbilge Awaiting requested review from armanbilge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpilquist @SystemFw