Set tlJdkRelease := 8 for all modules but io
#2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Mar 10, 2022
| (lastOutBuffer: Buffer).clear() | ||
| lastOutBuffer.clear() |
There was a problem hiding this comment.
This is more about making a point :P we can revert to play it safe.
There was a problem hiding this comment.
Yeah let's revert these and the flip ones below. When we need to target 9+ I don't want to have to fix these all over again.
vasilmkd
approved these changes
Mar 10, 2022
|
In fact, this suggests the solution is to isolate the JDK 16 stuff into its own tiny module, which fs2-io can depend on. Then, we can compile everything but that with this release flag. |
|
Okay with this PR but not okay with factoring out a new module. Too complex. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although @vasilmkd's release flag idea doesn't work for the io module, there's no reason we shouldn't apply it for all the other modules.