Fix Collector.supportsFactory #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalmungSan
commented
Feb 20, 2022
There was a problem hiding this comment.
I originally thought that with this change we could also "remove" the other Factory related implicit, but it seems no. It turns out that things like List are not a Factory[A, List[A]] but rather they provide an implicit conversion to such type but the compiler doesn't apply two implicit conversions at the same time.
| implicit def supportsFactory[A, C[_], B]( | ||
| f: Factory[A, C[B]] | ||
| ): Collector.Aux[A, C[B]] = make(Builder.fromFactory(f)) | ||
| implicit def supportsCollectionFactory[A, C](f: Factory[A, C]): Collector.Aux[A, C] = |
There was a problem hiding this comment.
If anyone has a better name I am all ears.
| @@ -50,6 +52,9 @@ private[fs2] trait CollectorPlatform { self: Collector.type => | |||
| } | |||
|
|
|||
| private[fs2] trait BuilderPlatform { self: Collector.Builder.type => | |||
| def fromCollectionFactory[A, C](f: Factory[A, C]): Builder[A, C] = | |||
| fromBuilder(f.newBuilder) | |||
|
|
|||
| def fromFactory[A, C[_], B](f: Factory[A, C[B]]): Builder[A, C[B]] = | |||
There was a problem hiding this comment.
Should we deprecate this one?
| builder: collection.mutable.Builder[A, C[B]] | ||
| ): Builder[A, C[B]] = | ||
| new Builder[A, C[B]] { | ||
| protected def fromBuilder[A, C]( |
There was a problem hiding this comment.
I hope this change makes sense and doesn't break binary compatibility.
Although, the code compiled without it so we revert it if you prefer.
BalmungSan
force-pushed
the
fix-collector-iterable-factory
branch
from
3849ce9 to
4c6c0ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK this is the best practice and allows types like
BitSetto be properly used.