Do not withhold emission in pauseWhen
#2813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pauseWhen should emit elements as soon as it wakes up, instead of checking for the need to pause again.
The difference in behaviour came up when I was implementing this (very complex) combinator for a user, which alternates between two streams upon a timeout.
Given how complex the example is, and how hard it is to engineer alternative code that would trigger a difference in behaviour between the new and old implementation of
pauseWhen
, I haven't added a test covering my change. Let me know if you want me to try harder finding a minimised test