Fix build warnings #2769
Merged
Fix build warnings #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
reviewed
Dec 24, 2021
| @@ -305,7 +305,7 @@ private[fs2] trait ioplatform { | |||
| /** Stream of bytes read asynchronously from standard input. | |||
| * Takes a dummy `Int` parameter for source-compatibility with JVM. | |||
| */ | |||
| @nowarn("cat=unused") | |||
| @nowarn // ("cat=unused") - unsupported category on scala 3 | |||
There was a problem hiding this comment.
Suggested change
| @nowarn // ("cat=unused") - unsupported category on scala 3 | |
| @nowarn("msg=never used") |
h/t @bplommer when we setup Scala 3 fatal warnings for http4s
|
The test failures are a bit worrisome... I assume the cause is the change to |
…l create an ArraySlice
|
Oh hm, I bet it's actually this change: ThisBuild / Test / javaOptions ++= Seq(
"-Dscala.concurrent.context.minThreads=8",
"-Dscala.concurrent.context.numThreads=8",
"-Dscala.concurrent.context.maxThreads=8"
) |
… parallel test execution, use cross-friendly nowarn unused trick
|
OK this should be good to go now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.