Files walk order #2756
Merged
Files walk order #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikiforo
reviewed
Dec 17, 2021
| .flatMap { path => | ||
| go(path, maxDepth - 1, attr.fileKey.toRight(start) :: ancestry) | ||
| } | ||
| .recoverWith { case _ => |
| .flatMap { path => | ||
| go(path, maxDepth - 1, attr.fileKey.toRight(start) :: ancestry) | ||
| } | ||
| .recoverWith { case _ => |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the behaviour of
walkto emit files in the order it visits them, which in turn enables streaming copy since it lets you create folders before copying the files they contain, which is a prerequisite forcopy.The behaviour of
walkin main is arguably a regression since it behaves differently fromNIO.walk, which it used to wrap, so I'm targettingmainwith a straight change, rather than a new method or a flag.