-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scalafmt-core to 3.1.1 #2708
Update scalafmt-core to 3.1.1 #2708
Conversation
6bd5da9
to
165231e
Compare
Scalafix tests are failing due to the reformat. We could either exclude scalafix from Scalafmt or we could figure out how to fix those tests. |
@mpilquist In Cats Effect we're facing the same issue. I usually revert the formatting changes to the output files manually. I don't have a better fix unfortunately. Here's an example PR. |
Oh huh, is this because of the way @scala-steward runs the Scalafmt on all subprojects or something? Whereas our |
Scala Steward runs the |
Thanks Frank! I hadn't gotten to the point of figuring out how to exclude. I like the .scalafmt.conf option. |
@fthomas We have a Here are the files in question: Thanks. |
Yes, I think so. It probably only reads one config per run. So if it is executed in the root dir, it will only read the I would keep the |
Updates org.scalameta:scalafmt-core from 3.1.0 to 3.1.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
Files still referring to the old version number
The following files still refer to the old version number (3.1.0).
You might want to review and update them manually.
Ignore future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains