Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalafmt-core to 3.1.1 #2708

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

scala-steward
Copy link
Contributor

Updates org.scalameta:scalafmt-core from 3.1.0 to 3.1.1.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (3.1.0).
You might want to review and update them manually.

.github/workflows/ci.yml
README.md
build.sbt
core/shared/src/main/scala/fs2/Stream.scala
core/shared/src/main/scala/fs2/text.scala
io/js/yarn.lock
io/jvm/src/main/scala/fs2/io/file/DeprecatedFilesApi.scala
node/js/yarn.lock
Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains

@scala-steward scala-steward force-pushed the update/scalafmt-core-3.1.1 branch from 6bd5da9 to 165231e Compare November 13, 2021 01:50
@mpilquist
Copy link
Member

Scalafix tests are failing due to the reformat. We could either exclude scalafix from Scalafmt or we could figure out how to fix those tests.

@vasilmkd
Copy link
Member

@mpilquist In Cats Effect we're facing the same issue. I usually revert the formatting changes to the output files manually. I don't have a better fix unfortunately.

Here's an example PR.

typelevel/cats-effect#2538

@mpilquist
Copy link
Member

Oh huh, is this because of the way @scala-steward runs the Scalafmt on all subprojects or something? Whereas our fmtCheck/fmt alias only runs it on certain subprojects?

@fthomas
Copy link
Member

fthomas commented Nov 16, 2021

Scala Steward runs the scalafmt binary in the root directory for reformatting instead of using the sbt-scalafmt plugin. Excluding the scalafix/ directory in .scalafmt.conf sounds like a sensible solution to me.

@mpilquist
Copy link
Member

Thanks Frank! I hadn't gotten to the point of figuring out how to exclude. I like the .scalafmt.conf option.

@vasilmkd
Copy link
Member

@fthomas We have a .scalafmt.conf inside scalafix/ in Cats Effect. That seems ignored? Do we get anything from having that file or can we remove it in favor of an ignore configuration in the root config file?

Here are the files in question:
https://github.com/typelevel/cats-effect/blob/c26a1ea4b1d113abb7c9e6c9c7f72e4dd86fbcb5/scalafix/.scalafmt.conf
https://github.com/typelevel/cats-effect/blob/c26a1ea4b1d113abb7c9e6c9c7f72e4dd86fbcb5/.scalafmt.conf

Thanks.

@fthomas
Copy link
Member

fthomas commented Nov 16, 2021

@vasilmkd

We have a .scalafmt.conf inside scalafix/ in Cats Effect. That seems ignored?

Yes, I think so. It probably only reads one config per run. So if it is executed in the root dir, it will only read the .scalafmt.conf there.

I would keep the scalafix/.scalafmt.conf in place and just add project.excludeFilters = [ "scalafix/*" ] (or is it excludePaths?) to the root configuration.

@mpilquist mpilquist merged commit 165231e into typelevel:main Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants