Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend broadcastThrough documentation #2621

Merged
merged 3 commits into from
Nov 30, 2021
Merged

Extend broadcastThrough documentation #2621

merged 3 commits into from
Nov 30, 2021

Conversation

diesalbla
Copy link
Contributor

@diesalbla diesalbla commented Sep 19, 2021 •
edited
Loading

Opened to address some of the inaccuracies discussed in #2600

  • Formulate the coordination condition as: "no pipe can pull and start processing any source chunk until after all pipes have pulled and started processing the previous chunk", which is a bit more accurate than "are done"

@diesalbla diesalbla force-pushed the broadcastThrough_docs branch from fc9dc1c to 0e9d92d Compare September 19, 2021 20:09
@diesalbla diesalbla marked this pull request as draft September 20, 2021 17:54
@diesalbla diesalbla force-pushed the broadcastThrough_docs branch 3 times, most recently from 2861b3d to 11ac03d Compare September 26, 2021 22:28
@diesalbla diesalbla changed the title Stream - Extend documentation of broadcastThrough. Extend and corred broadcastThrough documentation Sep 26, 2021
@diesalbla diesalbla marked this pull request as ready for review September 26, 2021 22:29
@diesalbla diesalbla requested a review from SystemFw September 26, 2021 22:30
@diesalbla diesalbla mentioned this pull request Sep 26, 2021
Open
@diesalbla diesalbla changed the title Extend and corred broadcastThrough documentation Extend broadcastThrough documentation Sep 26, 2021
@diesalbla
Stream - Extend documentation of broadcastThrough.
7564fb9
@diesalbla
BroadcastThrough Documentation - More accuracy.
acf19a5 
The previous explanation was for a model of a single
shared buffer location, but the actual working of Topic
is that of one buffer per subscriber.
@diesalbla diesalbla force-pushed the broadcastThrough_docs branch from 588d3f4 to acf19a5 Compare September 28, 2021 09:35
@diesalbla diesalbla requested a review from mpilquist September 29, 2021 12:25
@mpilquist mpilquist merged commit 647649b into typelevel:main Nov 30, 2021
@diesalbla diesalbla deleted the broadcastThrough_docs branch December 26, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpilquist mpilquist mpilquist left review comments

@SystemFw SystemFw Awaiting requested review from SystemFw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diesalbla @mpilquist