Update scalafix to the latest version, fix some rules and run the tests in the CI #2415
Conversation
|
It seems like this is hitting some incompatibilities with JDK 16. I need to investigate further. |
build.sbt
Outdated
| ThisBuild / crossScalaVersions := Seq("3.0.0", "2.12.13", "2.13.5") | ||
| val NewScala = "2.13.5" | ||
|
|
||
| ThisBuild / crossScalaVersions := Seq("3.0.0", "2.12.13", NewScala) |
There was a problem hiding this comment.
I am not sure if your scalafix rules are meant to run against 3.0.0 sources, but if that's the case (and eventually anyway), you should consider tweaking the build to test that scenario.
See liancheng/scalafix-organize-imports#179 for an example (which manually applies the updated scalafix.g8 template).
There was a problem hiding this comment.
They aren't, we're testing them against 2.13, but you're right that they are available for 3.0 as well. Not sure if that's a strictly negative thing.
There was a problem hiding this comment.
@bjaglin feel free to improve the situation after this PR is merged (or even as a part of it, whatever is easier for you). 😄
There was a problem hiding this comment.
@vasilmkd sure, willl open a separate PR
Please review carefully. I believe the
sbt-scalafixthat was being updated byscala-stewardwas not actually doing anything. This PR also enables running the scalafix tests in the CI, similar to Cats Effect's CI.