Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add partial apply factory for SignallingRef #2406

Merged
merged 1 commit into from
May 21, 2021
Merged

Add partial apply factory for SignallingRef #2406

merged 1 commit into from
May 21, 2021

Conversation

IVaSmi
Copy link
Contributor

@IVaSmi IVaSmi commented May 16, 2021 •
edited by kubukoz
Loading

Closes #2396.

The primary intention of this PR is to add partial apply factory for SignallingRef.

@vasilmkd
Copy link
Member

Neat little trick with the dummy boolean value. I think you need to run sbt scalafmtAll to pass the CI. 😄

@IVaSmi IVaSmi force-pushed the add-partial-apply-for-SignallingRef branch from dc76c90 to 1bb7eee Compare May 16, 2021 21:42
@IVaSmi
Copy link
Contributor Author

IVaSmi commented May 16, 2021

Neat little trick with the dummy boolean value. I think you need to run sbt scalafmtAll to pass the CI. 😄

Hurried... I fixed that. 😅

@mpilquist mpilquist merged commit fb5d318 into typelevel:main May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubukoz kubukoz kubukoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add partial apply factory for SignallingRef
4 participants
@IVaSmi @vasilmkd @kubukoz @mpilquist