Add Stream#chunkAll #1855
Merged
Add Stream#chunkAll #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diesalbla
reviewed
Apr 25, 2020
| def chunkAll: Stream[F, Chunk[O]] = { | ||
| def loop(s: Stream[F, O], acc: Chunk.Queue[O]): Pull[F, Chunk[O], Unit] = | ||
| s.pull.uncons.flatMap { | ||
| case Some((hd, tl)) => loop(tl, acc :+ hd) |
There was a problem hiding this comment.
Two questions here:
- Would we gain something if we were to get the chunks from the original
s.pull, and iterate and append chunk by chunk, rather than element-by-element? - Would we benefit from having a mutable constructor of an immutable chunk, much in the same way as Scala collections have mutable builders for then-immutable structures (e.g.
ListBufferforList)?
There was a problem hiding this comment.
Yep, this implementation does both already more or less. We're pulling full chunks from the source (via uncons, not uncons1) and we're appending those chunks to a Chunk.Queue, which preserves them as whole chunks during the building phase. Only when toChunk is called on that queue are they all concatenated in to a single chunk.
diesalbla
approved these changes
Apr 25, 2020
SystemFw
approved these changes
Apr 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1834