Changed Pull#{stream,streamNoScope} to require Unit result type #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was something I noticed when working on the topic/fs3 branch. This PR changes the
streamandstreamNoScopemethods to require the result type of thePullto beUnit. This is thePullequivalent of-Xfatal-warnings -Ywarn-value-discard-- folks can explicitly indicate they want the result type thrown away viap.void.stream.Note how many cases in fs2 itself were using a nonsensical result type -- these are vestiges of the old 0.9
PullAPI where termination has to be explicitly signaled via anOptionresult type.