Fix logging for streaming and updateMany #2064
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces three new functions in the high level API for Connection (
doobie.hi.HC
).Fixes #533, #1888
These helpers offer a few improvements:
executeWithResultSet
This is a generalization for any query that executes a PreparedStatement and processes a ResultSet. This covers two cases:
executeQuery
)RETURNING
/.executeUpdate + .getGeneratedKeys
)All query methods like Query#to and Update#withUniqueGeneratedKeys have switched to use this internally.
executeWithoutResultSet
Similar to
executeWithResultSet
but for queries that doesn't need to process a ResultSet (i.e. simple updates).Methods like
Update
'supdateMany
,update
have switched to use this internallystream
This will be replacing the existing
stream
method (which is currently deprecated because it doesn't support logging)Query#stream
and all theUpdate#withGeneratedKeys*
have switched to this internally.Further improvements can probably be made on top of these methods so users don't need to construct
LoggingInfo
themselves.