Reduce compilation warnings in tests
#4083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satorg
force-pushed
the
reduce-tests-warnings
branch
from
b09ec19 to
98478c8
Compare
|
This PR is still awaiting its hero who would dare to review it :) |
danicheg
reviewed
Dec 23, 2021
satorg
force-pushed
the
reduce-tests-warnings
branch
from
98478c8 to
7e21c4a
Compare
satorg
force-pushed
the
reduce-tests-warnings
branch
from
7e21c4a to
045ac91
Compare
|
Hi folks! May I draw a fraction of your attention to this PR please? There's nothing dangerous with it – it just reduces compilation warnings from tests which can help to alleviate developer experience tremendously while they're working on any tests as well as coding in any IDE. |
johnynek
approved these changes
Apr 2, 2022
|
@rossabaker @johnynek thank you guys! |
|
Thank you! Sorry for the latency! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to improve code hygiene a bit by reducing amount of warnings while compiling the
testsJVM,testsJSandtestsNativemodules.No tests are removed nor disabled, no other changes besides the
tests*modules. But some tests were tossed over different suites or suite mixins.Caveat: because
@nowarnannotation is not supported in Scala 3.0.x, for this cross-build configuration most of the warnings will still remain. But things should get improved once the project upgrades to Scala 3.1.x.Note: also in all changed files the "Organize Imports" (vs-code+metals) command was applied.