Reverted binary incompatible changes to generated parallel syntax

[barambani]

In relation to this PR #2692, I realise only now that the same problem I had with the Semigroupal syntax is also affecting the boilerplate parallel syntax. I reverted the change to the generator and added a MimaExceptions test.

[codecov-io]

Codecov Report

Merging #2702 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2702      +/-   ##
==========================================
- Coverage   95.13%   95.11%   -0.02%     
==========================================
  Files         365      365              
  Lines        6780     6781       +1     
  Branches      294      294              
==========================================
  Hits         6450     6450              
- Misses        330      331       +1

Impacted Files	Coverage Δ
...patTest/src/main/scala/catsBC/MimaExceptions.scala	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eedb47c...69356ef. Read the comment docs.

[kailuowang]

Thanks

[kailuowang]

Just so that I know that the MimaException test still works, the test you added failed with the private val change you made?

[barambani]

The problematic bit is the syntax ops extending AnyVal. With

private[syntax] final class Tuple${arity}ParallelOps[M[_], ${`A..N`}](private val $tupleTpe)

the test result is

[info] MimaExceptionsTest:
[info] - is binary compatible
[info] Run completed in 960 milliseconds.
[info] Total number of tests run: 1
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 99 s

but changing it to

private[syntax] final class Tuple${arity}ParallelOps[M[_], ${`A..N`}](private val $tupleTpe) extends AnyVal

the test fails

[info] MimaExceptionsTest:
[info] catsBC.MimaExceptionsTest *** ABORTED ***
[info]   java.lang.NoSuchMethodError: cats.implicits$.catsSyntaxTuple3Parallel(Lscala/Tuple3;)Lcats/syntax/Tuple3ParallelOps;
[info]   at catsBC.MimaExceptions$.isBinaryCompatible(MimaExceptions.scala:30)
[info]   at catsBC.MimaExceptionsTest$$anonfun$1.apply(MimaExceptionsTest.scala:7)
[info]   at catsBC.MimaExceptionsTest$$anonfun$1.apply(MimaExceptionsTest.scala:7)
[info]   at org.scalatest.OutcomeOf$class.outcomeOf(OutcomeOf.scala:85)
[info]   at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:22)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:20)
[info]   at org.scalatest.FunSuiteLike$$anon$1.apply(FunSuiteLike.scala:186)
[info]   at org.scalatest.TestSuite$class.withFixture(TestSuite.scala:196)
[info]   at org.scalatest.FunSuite.withFixture(FunSuite.scala:1560)
[info]   ...

[kailuowang]

Ah didn't realize that it wasnt value class and you changed that. I think we should still make the call private.

[barambani]

Makes sense. I will do it 👍

[barambani]

could the 2.13's travis job be restarted ?

CommutativeGroup[BigDecimal].commutativeGroup.associative *** FAILED ***
  GeneratorDrivenPropertyCheckFailedException was thrown during property evaluation.
   (Discipline.scala:14)
    Falsified after 4 successful property evaluations.
    Location: (Discipline.scala:14)
    Occurred when passed generated values (
      arg0 = 7.11522893613707E+63,
      arg1 = -1.6701798045816614E+43,
      arg2 = -1.1744341123863878E+45
    )
    Label of failing property:
      Expected: 7.115228936137069998808864089567796E+63
      Received: 7.115228936137069998808864089567795E+63

[LukaJCB]

Thanks so much @barambani!

[barambani]

👍 , sorry it took a double PR to finish this.