Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Xmx in .jvmopts and build.sbt #2605

Merged
merged 3 commits into from
Nov 17, 2018

Conversation

Alistair-Johnson
Copy link
Contributor

Another attempt at fixing OOM's in build

So the .jvmopts sets max memory to 6G AND the (one) forked jvm for tests also sets memory to 6G (which by default would receive the same settings anyway, btw). So if my maths is correct, that‘s 12G in total on a machine that IIRC is only 7.5G.

So set .jvmopts to 3G and the forked JVM javaopts to also 3G

Supporting issue :
scalatest/scalatest#770,

NB:
„...to cap the memory for the main process + the forked process to be < 3G at any point of time. That would mean:
main process + SBT forked process + debugger process in test (if you created)
should not be > 3G“

„...providing the memory caps on the main process, forked, process, and children worked.“

Note that, if you follow the links, the same issue is reported for specs2 and also on laptops - ie not just on travis.

@codecov-io
Copy link

codecov-io commented Nov 11, 2018

Codecov Report

Merging #2605 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2605   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files         361      361           
  Lines        6657     6657           
  Branches      295      295           
=======================================
  Hits         6336     6336           
  Misses        321      321

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b6f8e...f498b25. Read the comment docs.

@kailuowang
Copy link
Contributor

Thanks!

@kailuowang kailuowang requested a review from ceedubs November 16, 2018 18:19
Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ceedubs ceedubs merged commit 533cc16 into typelevel:master Nov 17, 2018
@kailuowang kailuowang added this to the 1.5.0-RC1 milestone Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants