Override size in Chain instance #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be a slight optimization.
LukaJCB
reviewed
Aug 19, 2018
| @@ -538,6 +538,7 @@ private[data] sealed abstract class ChainInstances extends ChainInstances1 { | |||
| override def exists[A](fa: Chain[A])(p: A => Boolean): Boolean = fa.exists(p) | |||
| override def forall[A](fa: Chain[A])(p: A => Boolean): Boolean = fa.forall(p) | |||
| override def find[A](fa: Chain[A])(f: A => Boolean): Option[A] = fa.find(f) | |||
| override def size[A](fa: Chain[A]): Long = fa.length.toLong | |||
There was a problem hiding this comment.
fa.length already returns Long, so no need for the call to toLong :)
|
I'm pretty sure that it returned a long when I looked. Either i was looking
at outdated code or I'm seeing things :)
It might be a while before I'm at a computer to fix this.
…On Sun, Aug 19, 2018, 7:55 AM Luka Jacobowitz ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In core/src/main/scala/cats/data/Chain.scala
<#2425 (comment)>:
> @@ -538,6 +538,7 @@ private[data] sealed abstract class ChainInstances extends ChainInstances1 {
override def exists[A](fa: Chain[A])(p: A => Boolean): Boolean = fa.exists(p)
override def forall[A](fa: Chain[A])(p: A => Boolean): Boolean = fa.forall(p)
override def find[A](fa: Chain[A])(f: A => Boolean): Option[A] = fa.find(f)
+ override def size[A](fa: Chain[A]): Long = fa.length.toLong
fa.length already returns Long, so no need for the call to toLong :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2425 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA7sCWuuEghj3zcQHsxN4ubkG-7d-Ab-ks5uSaapgaJpZM4WDCy->
.
|
johnynek
reviewed
Aug 19, 2018
Codecov Report
@@ Coverage Diff @@
## master #2425 +/- ##
==========================================
- Coverage 95.22% 95.21% -0.02%
==========================================
Files 351 351
Lines 6368 6369 +1
Branches 279 281 +2
==========================================
Hits 6064 6064
- Misses 304 305 +1
Continue to review full report at Codecov.
|
LukaJCB
approved these changes
Aug 19, 2018
kailuowang
approved these changes
Aug 20, 2018
catostrophe
pushed a commit
to catostrophe/cats
that referenced
this pull request
Sep 15, 2018
* Override size in Chain instance This should be a slight optimization. * Update Chain.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a slight optimization.