Do redirect to look into cats-mtl for MonadCombine #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2035 +/- ##
=======================================
Coverage 95.25% 95.25%
=======================================
Files 305 305
Lines 5179 5179
Branches 127 126 -1
=======================================
Hits 4933 4933
Misses 246 246Continue to review full report at Codecov.
|
LukaJCB
reviewed
Nov 22, 2017
CHANGES.md
Outdated
| @@ -205,7 +205,8 @@ as many breaking changes as possible in this release before we lock down the API | |||
| * All `Unapply` enabled methods, e.g. `sequenceU`, `traverseU`, etc. are removed. `Unapply` | |||
| enabled syntax ops are also removed. Please use the partial unification SI-2712 fix | |||
| instead. The easiest way might be this [sbt-plugin](https://github.com/fiadliel/sbt-partial-unification). | |||
| * `FunctorFilter`, `MonadCombine`, `MonadFilter`, `MonadReader`, `MonadState`, `MonadTrans`, `MonadWriter` and `TraverseFilter` are no longer in `cats`, the functionalities they provided are inherited by the new [cats-mtl](https://github.com/typelevel/cats-mtl) project. Please check [here](https://github.com/typelevel/cats-mtl#migration-guide) for migration guide. | |||
| * `FunctorFilter`, `MonadFilter`, `MonadReader`, `MonadState`, `MonadTrans`, `MonadWriter` and `TraverseFilter` are no longer in `cats`, the functionalities they provided are inherited by the new [cats-mtl](https://github.com/typelevel/cats-mtl) project. Please check [here](https://github.com/typelevel/cats-mtl#migration-guide) for migration guide. | |||
| * `MonadCombine` is no longer in cats. Use `Alternative` or `Monad` + `K` instead. | |||
|
Done :-). |
kailuowang
approved these changes
Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...Because it's not there. @LukaJCB++ on gitter pointed out that the use cases for MonadCombine are handled using
AlternativeorMonad+MonoidKnow.Note: it appears there's a MonadCombineSuite, which provides a test for a single method of
Alternative. If I can get some time I'll rename it & add the missing tests.