FreeT as stack-safe Kleisli #1764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1764 +/- ##
=======================================
Coverage 94.17% 94.17%
=======================================
Files 256 256
Lines 4208 4208
Branches 93 89 -4
=======================================
Hits 3963 3963
Misses 245 245Continue to review full report at Codecov.
|
andyscott
reviewed
Jul 9, 2017
| @@ -4,4 +4,6 @@ package object free { | |||
| /** Alias for the free monad over the `Function0` functor. */ | |||
| type Trampoline[A] = Free[Function0, A] | |||
| object Trampoline extends TrampolineFunctions | |||
| type StacksafeKleisli[F[_], A, B] = FreeT[A => ?, F, B] | |||
There was a problem hiding this comment.
The "S" in "Safe" is already capitalized in StackSafeMonad, so it should probably be capitalized here for consistency.
|
@johnynek Has a better solution in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a tentative solution to #1733. If this is merged another issue should be created for the hand-inlined version of this, if we end up wanting it.