-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scala 2.12.0-RC1 #1382
Add scala 2.12.0-RC1 #1382
Conversation
Re failing build on 2.12.0-RC1 this is during [tut] compiling: ./docs/src/main/tut/either.md
[tut] *** Error reported at ./docs/src/main/tut/either.md:239: failure was asserted but no failure occurred
doApp: scala.util.Either[Object,ServiceValue] So this diff passes in 2.12.0-RC1 only, but is not the solution, just a helper/illustration: @@ -235,7 +235,7 @@ object Service {
Let's say we have an application that wants to do database things, and then take database
values and do service things. Glancing at the types, it looks like `flatMap` will do it.
-```tut:fail:silent
+```tut:silent
def doApp = Database.databaseThings().flatMap(Service.serviceThings) This is all clearly due to new 2.11.8 build failure looks like the old OOM issues, so I'll turn of some instrumentation as I mentioned ^^ |
Actually, the 2.11 build failure is identical to https://travis-ci.org/typelevel/cats/jobs/161257117 so I'm done here for now 😄 |
@BennyHill you don't need to compile scoverage anymore. You can do something like this: plugins.sbt: build.sbt |
@magicknot Thanks! I just confirmed locally that that works. |
I know - I did most of the changes for scoverage along with @paulp 😄 |
But we do need the more recent sbt plugin as well, |
Current coverage is 91.84% (diff: 100%)@@ master #1382 diff @@
==========================================
Files 240 240
Lines 3610 3567 -43
Methods 3546 3500 -46
Messages 0 0
Branches 63 67 +4
==========================================
- Hits 3310 3276 -34
+ Misses 300 291 -9
Partials 0 0
|
Todo: Add new issue with |
Ref two scala issues: |
Mind if I close this, @BennyHill, since these commits are in #1415? |
Closing since these commits are in #1415 |
This PR adds 2.12-0-RC1 support.
Please note that
makesite
has been disabled due to an error in 2.12, see comments