Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NEM[K, V] => NEL[(K, V)] and vice versa, NEL#toNes #2346

Closed
kubukoz opened this issue Jul 28, 2018 · 9 comments
Closed

Add NEM[K, V] => NEL[(K, V)] and vice versa, NEL#toNes #2346

kubukoz opened this issue Jul 28, 2018 · 9 comments
Labels
help wanted low-hanging fruit

Comments

@kubukoz
Copy link
Member

kubukoz commented Jul 28, 2018

No description provided.

@denisrosca
Copy link
Contributor

Wouldn't NEL[(K, V)] have to change to NEM[K, NEL[V]]? Or should the transformation require V: Semigroup?

@kubukoz
Copy link
Member Author

kubukoz commented Jul 30, 2018

I think that would resemble groupBy or something like that.

What I meant in the issue was equivalents to stdlib's Map#toList and List#toMap :)

Also, adding NEL#toNes to the issue as I've had a few usecases for it recently too.

@kubukoz kubukoz changed the title Add NEM[K, V] => NEL[(K, V)] and vice versa Add NEM[K, V] => NEL[(K, V)] and vice versa, NEL#toNes Jul 30, 2018
@CucumisSativus
Copy link
Contributor

Guys, I'd like to work on this if its still relevant :)

@LukaJCB
Copy link
Member

LukaJCB commented Sep 24, 2018

@CucumisSativus Go right ahead :)

CucumisSativus added a commit to CucumisSativus/cats that referenced this issue Sep 25, 2018
@CucumisSativus
Add NonEmptyMap#toNonEmptyList (issue typelevel#2346)
1daf808
@CucumisSativus CucumisSativus mentioned this issue Sep 25, 2018
Merged
CucumisSativus added a commit to CucumisSativus/cats that referenced this issue Sep 26, 2018
@CucumisSativus
Add NonEmptyMap#toNonEmptyList (issue typelevel#2346)
66d8957
kailuowang pushed a commit that referenced this issue Sep 27, 2018
@CucumisSativus @kailuowang
Add NonEmptyMap#toNonEmptyList (issue #2346) (#2535)
4acdbb9
CucumisSativus added a commit to CucumisSativus/cats that referenced this issue Sep 29, 2018
@CucumisSativus
Add NonEmptyList#toNem (issue typelevel#2346)
2244f7f
@calvinbrown085
Copy link
Contributor

@kubukoz @CucumisSativus Can we close this? Looks like the PR has been merged

@CucumisSativus
Copy link
Contributor

@calvinbrown085 I split it into 3 PR to make reviews easier. One is merged. The second is awaiting second confirmation #2541 and my third is waiting for the second to be merged :)

@calvinbrown085
Copy link
Contributor

Ah fair enough :)

kailuowang pushed a commit that referenced this issue Oct 8, 2018
@CucumisSativus @kailuowang
Add NonEmptyList#toNem (issue #2346) (#2541)
e2af59a
CucumisSativus added a commit to CucumisSativus/cats that referenced this issue Oct 14, 2018
@CucumisSativus
Add NonEmptyList#toNes (issue typelevel#2346)
7fc5994
@CucumisSativus CucumisSativus mentioned this issue Oct 14, 2018
Merged
kailuowang pushed a commit that referenced this issue Oct 24, 2018
@CucumisSativus @kailuowang
Add NonEmptyList#toNes (issue #2346) (#2557)
8620303 
* Add NonEmptyList#toNes (issue #2346)

* Fixed NonEmptyList.scala formating

* Fixed NonEmptyListSuite.scala formating

* Revert "Fixed NonEmptyListSuite.scala formating"

This reverts commit 1a4ff0d.

* Fixed NonEmptyListSuite.scala formating, this time for sure
@CucumisSativus
Copy link
Contributor

Okay, issue can be closed. All pull requests are merged

@kubukoz
Copy link
Member Author

kubukoz commented Oct 24, 2018

Closing ;) thanks!

@kubukoz kubukoz closed this as completed Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted low-hanging fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kubukoz @CucumisSativus @denisrosca @calvinbrown085 @LukaJCB