Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MonadTests[M].stackUnsafeMonad overflows - MonadLaws.tailRecMStackSafety should be a def #1463

Closed
TrustNoOne opened this issue Nov 10, 2016 · 3 comments · Fixed by #1465
Closed

MonadTests[M].stackUnsafeMonad overflows - MonadLaws.tailRecMStackSafety should be a def #1463

TrustNoOne opened this issue Nov 10, 2016 · 3 comments · Fixed by #1465
Assignees
@kailuowang

Comments

@TrustNoOne
Copy link

MonadLaws.tailRecMStackSafety is currently a val; this means MonadTests[M].stackUnsafeMonad checks for stack safety anyway as soon as the MonadLaws[M] instance is created
@non
Copy link
Contributor

non commented Nov 10, 2016

Good catch! I think a lazy val might be best but a def would work too.

@edmundnoble
Copy link
Contributor

edmundnoble commented Nov 10, 2016 •
edited
Loading

We should also look into testing stackUnsafeMonad by changing MonadTestsTests to use a stack-unsafe monad.

@travisbrown
Copy link
Contributor

Ugh, I think this must have been my fault. Thanks for catching it, @TrustNoOne.

kailuowang added a commit that referenced this issue Nov 15, 2016
@kailuowang
make tailRecMStackSafety lazy val
7cbbb20 
fixes #1463
@kailuowang kailuowang mentioned this issue Nov 15, 2016
Merged
@kailuowang kailuowang self-assigned this Nov 15, 2016
@stew stew removed the in progress label Nov 28, 2016
johnynek pushed a commit that referenced this issue Nov 28, 2016
@kailuowang @johnynek
make tailRecMStackSafety lazy val (#1465)
47acf7f 
fixes #1463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kailuowang kailuowang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make tailRecMStackSafety lazy val typelevel/cats
6 participants
@stew @kailuowang @non @travisbrown @edmundnoble @TrustNoOne