Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Cirrus only for labeled PRs or tags #3842

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

armanbilge
Copy link
Member

No description provided.

Copy link
Contributor

@samspills samspills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Member

@djspiewak djspiewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also make them run unconditionally for release tags? Also we should probably create the labels. :-)

@@ -1,4 +1,6 @@
jvm_highcore_task:
only_if: $CIRRUS_TAG != '' || $CIRRUS_PR != ''
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djspiewak they already run unconditionally for release tags. Unless I'm missing your point.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood the diff. lgtm then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants