Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Global EC for CatsResource #555

Open
wants to merge 2 commits into
base: series/1.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
/*
* Copyright 2020 Typelevel
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package cats.effect.testing.scalatest

import org.scalatest.FixtureAsyncTestSuite

import scala.concurrent.ExecutionContext

trait GlobalExecutionContext { this: FixtureAsyncTestSuite =>

override implicit def executionContext: ExecutionContext = scala.scalajs.concurrent.JSExecutionContext.queue

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
/*
* Copyright 2020 Typelevel
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package cats.effect.testing.scalatest

import org.scalatest.FixtureAsyncTestSuite

import scala.concurrent.ExecutionContext

trait GlobalExecutionContext { this: FixtureAsyncTestSuite =>

override implicit def executionContext: ExecutionContext = ExecutionContext.global

}
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import org.scalatest.{BeforeAndAfterAll, FixtureAsyncTestSuite, FutureOutcome, O

import scala.concurrent.duration._

trait CatsResource[F[_], A] extends BeforeAndAfterAll { this: FixtureAsyncTestSuite =>
trait CatsResource[F[_], A] extends BeforeAndAfterAll with GlobalExecutionContext { this: FixtureAsyncTestSuite =>

def ResourceAsync: Async[F]
private[this] implicit def _ResourceAsync: Async[F] = ResourceAsync
Expand Down Expand Up @@ -73,11 +73,18 @@ trait CatsResource[F[_], A] extends BeforeAndAfterAll { this: FixtureAsyncTestSu
}

override def afterAll(): Unit = {
UnsafeRun[F].unsafeToFuture(shutdown, finiteResourceTimeout)

gate = None
value = None
shutdown = ().pure[F]
UnsafeRun[F].unsafeToFuture(
for {
_ <- shutdown
_ <- Sync[F] delay {
gate = None
value = None
shutdown = ().pure[F]
}
} yield (),
finiteResourceTimeout
)
()
}

override type FixtureParam = A
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
/*
* Copyright 2020 Typelevel
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package cats.effect.testing.scalatest

import cats.effect.{IO, Resource}
import org.scalatest.concurrent.Eventually
import org.scalatest.events.Event
import org.scalatest.{Args, Reporter}
import org.scalatest.matchers.must.Matchers._
import org.scalatest.wordspec.{AsyncWordSpec, FixtureAsyncWordSpec}

import scala.concurrent.duration._

class CatsResourceAllocationSpecs extends AsyncWordSpec with Eventually {

override implicit def patienceConfig: PatienceConfig =
super.patienceConfig.copy(timeout = 1.second)

@volatile
var beforeCalled: Int = 0

@volatile
var afterCalled: Int = 0

class ResourceSpec
extends FixtureAsyncWordSpec
with AsyncIOSpec
with CatsResourceIO[Unit] {

override val resource: Resource[IO, Unit] =
Resource.make { IO.delay { beforeCalled += 1 } } { _ =>
IO.delay { afterCalled += 1 }
}

"test" should {
"doFoo" in { _ => true mustBe true }
}
}

val reporter: Reporter = (_: Event) => ()

"cats resource allocation" should {
"release the resource" in {

val outerResourceSpec = new ResourceSpec

outerResourceSpec.run(None, Args(reporter))

eventually {
beforeCalled mustBe 1
afterCalled mustBe 1
}
}
}
}
Loading