Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit ScalaTest dependency to its core library #418

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Limit ScalaTest dependency to its core library #418

merged 1 commit into from
Feb 22, 2023

Conversation

kaharlichenko
Copy link

cats-effect-testing-scalatest only depends on the classes from scalatest-core.

By narrowing down the dependency we let users cherry-pick specs and matchers they use in their project instead of pulling in the whole ScalaTest glory.

Copy link
Member

@djspiewak djspiewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems extremely reasonable to me. :-) Needs a merge though.

@kaharlichenko
Copy link
Author

@djspiewak, I brought it up to date with the recent changes. Should I create another PR based on series/0.x as well?

@djspiewak
Copy link
Member

Should I create another PR based on series/0.x as well?

I think at this point, 0.x is EOL, so it's fair to just concentrate on 1.x.

@djspiewak djspiewak merged commit 0cd8fb4 into typelevel:series/1.x Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants