Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace serial scalatest ExecutionContext with global #360

Merged
merged 8 commits into from
Oct 1, 2022

Conversation

custommonkey
Copy link
Contributor

Fix for #145

Copy link
Member

@djspiewak djspiewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to remove the createIORuntime helper? I only vaguely remember some of this stuff. I do agree with removing the serial executor though. If people want that semantic, TestControl exists and does the job better.

@custommonkey
Copy link
Contributor Author

createIORuntime is used in minitest so it can't go completely and updating AsyncIOSpec to not extend RuntimePlatform is a binary breaking change so that seems a little harsh.

ATM I'm trying to figure out why it works with the jvm, but no js. It seems scalatest has specific behaviour for js https://github.com/scalatest/scalatest/blob/7aeda262e249a66d2319b6b2f5daa1b7d0cf9a4f/jvm/core/src/main/scala/org/scalatest/concurrent/SerialExecutionContext.scala#L118 so I might need to use a variation to provide the correct runtime.

@djspiewak
Copy link
Member

Ooooooh, ScalaTest just doesn't let you use alternative executors on JavaScript. That's actually really annoying.

@djspiewak djspiewak merged commit bbdaa43 into typelevel:series/1.x Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants