Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assertions to assertThrows #358

Merged
merged 2 commits into from
Oct 29, 2022
Merged

Add assertions to assertThrows #358

merged 2 commits into from
Oct 29, 2022

Conversation

custommonkey
Copy link
Contributor

@custommonkey custommonkey commented Sep 21, 2022 •
edited
Loading

Add assertThrowsError which gives access to the Throwable error not just the message.

djspiewak
djspiewak approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@djspiewak djspiewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I missed this. Thank you! Good change.

@djspiewak djspiewak merged commit 296ae22 into typelevel:series/1.x Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djspiewak djspiewak djspiewak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@custommonkey @djspiewak