Fix django_stubs_ext directory collision with installation name
#1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves `django_stubs_ext` to a directory named `ext/`, which doesn't collide with its installation name.. Any name other than `django_stubs_ext` works really. This should fix odd test suite errors happening depending on environment and depending from where you invoke python(`pytest`). Although, unfortunately, people having installed pinned version(s) via `&subdirectory=django_stubs_ext` have to update their url to `&subdirectory=ext`
…installation name
…n with installation name
flaeppe
commented
Aug 30, 2023
| @@ -68,7 +68,7 @@ jobs: | |||
|
|
|||
| # Must match `shard` definition in the test matrix: | |||
| - name: Run tests | |||
| run: PYTHONPATH='.' pytest --num-shards=4 --shard-id=${{ matrix.shard }} | |||
| run: PYTHONPATH='.' pytest --num-shards=4 --shard-id=${{ matrix.shard }} tests | |||
There was a problem hiding this comment.
It appears django_stubs_ext/tests ran twice previously. Once under test job and once under matrix-test job
sobolevn
approved these changes
Aug 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Moves
django_stubs_extto a directory namedext/, which doesn't collide with its installation name.. Any name other thandjango_stubs_extworks really.This should fix odd test suite errors happening depending on environment and depending from where you invoke python(
pytest).Although, unfortunately, people having installed pinned version(s) via
&subdirectory=django_stubs_exthave to update their url to&subdirectory=extRelated issues
Refs: #1627
Refs: #1658 (comment)