Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cucumber BDD dependencies for C++ #572

Draft
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

krishnangovindraj
Copy link
Member

@krishnangovindraj krishnangovindraj commented Jan 19, 2024

Usage and product changes

Updates the cucumber messages & gherkin parser used by the C++ BDD tests.

Implementation

  • Updates our code to reflect the updates (re-organised includes & namespacing)

@typedb-bot
Copy link
Member

typedb-bot commented Jan 19, 2024

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@krishnangovindraj krishnangovindraj force-pushed the update-cpp-cucumber-deps branch from 3c6ef12 to 3d9832b Compare March 27, 2024 13:06
@krishnangovindraj krishnangovindraj added type: build dependencies Pull requests that update a dependency file and removed x: do not merge labels Mar 27, 2024
@krishnangovindraj krishnangovindraj marked this pull request as ready for review March 27, 2024 13:07
@krishnangovindraj krishnangovindraj force-pushed the update-cpp-cucumber-deps branch from 3d9832b to a9d1037 Compare April 3, 2024 09:38
@krishnangovindraj krishnangovindraj self-assigned this Apr 3, 2024
@krishnangovindraj krishnangovindraj force-pushed the update-cpp-cucumber-deps branch from 4f0a7e4 to 6daebc3 Compare April 3, 2024 15:23
@krishnangovindraj krishnangovindraj marked this pull request as draft May 20, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file type: build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants