Break Grakn-Core Dependency #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyingsilverfin
requested review from
haikalpribadi and
marco-scoppetta
as code owners
| case BOOLEAN: | ||
| return AttributeType.DataType.BOOLEAN; | ||
| return grakn.client.concept.AttributeType.DataType.BOOLEAN; |
There was a problem hiding this comment.
these package addresses can be collapsed, @flyingsilverfin. It's okay to do it in the next PR.
flyingsilverfin
added a commit
that referenced
this pull request
Oct 1, 2019
## What is the goal of this PR? Previous PR #39 neglected to implement `AutoClosable` on `Session`, which is expected in Grakn Core for now ## What are the changes implemented in this PR? * Implement `AutoClosable`
dmitrii-ubskii
added a commit
to dmitrii-ubskii/typedb-driver
that referenced
this pull request
Jul 13, 2023
## What is the goal of this PR? We improved parse errors handling in the `behaviour` test package. ## What are the changes implemented in this PR? We added asserts at the all stages of query processing for "`typeql define [...]`" and "`typeql insert [...]`" expressions. --------- Co-authored-by: Dmitrii Ubskii <[email protected]>
dmitrii-ubskii
pushed a commit
that referenced
this pull request
Aug 25, 2023
…ac-zip (#39) ## What is the goal of this PR? Test should unpack, start/stop Grakn distribution _within_ the test ## What are the changes implemented in this PR? * tests now depend on `@graknlabs_grakn_core//:assemble-mac-zip` via `data` * tests now unpack/start/stop Grakn before executing
dmitrii-ubskii
pushed a commit
to dmitrii-ubskii/typedb-driver
that referenced
this pull request
Aug 31, 2023
…5.2 (typedb#39) ## What is the goal of this PR? Grakn Core 1.5.2 introduced a protocol change which rendered `client-nodejs` version 1.5.1 and older incompatible. We have updated `client-nodejs` to allow it to connect to Grakn Core and KGMS 1.5.2. The changes that had been introduced are internal changes which did not affect the public API. ## What are the changes implemented in this PR? - Internally, `username` and `password` are now supplied when making the `Session.Open.Req` gRPC request as opposed to 1.5.1 where they were supplied when making the `Transaction.Open.Req` request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Remove code dependencies of Client-Java on Grakn Core, specifically
api.Transactionandgrakn.core.conceptinterfaces. This will allow us to update Client-Java independently of Grakn, only fixing compatibility issues mandated by the protocol, in line with the other drivers.Resolves #5288, #5289, and part of #5272
What are the changes implemented in this PR?
api.Transactionandgrakn.core.conceptinterface depenendencies in Client-JavaConceptITintobehavior, TODO refactor into BDD frameworkRemoteConcept.javaclasses to just followConcept.javapattern, removing theRemotenaming schemeAnswerhierarchy that was missing before.