Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeDB Client Rust dependencies: async runtimes, tokio-stream #423

Merged
merged 3 commits into from
Feb 23, 2023
Merged

TypeDB Client Rust dependencies: async runtimes, tokio-stream #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37ab169
keep track of Cargo.lock
dmitrii-ubskii Feb 22, 2023
cd77c95
extra client dependencies
dmitrii-ubskii Feb 22, 2023
6f1e5e1
update lockfile
dmitrii-ubskii Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ target
Cargo.lock
Cargo.toml
!library/crates/Cargo.toml
!library/crates/Cargo.lock
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crates-universe depends on this Cargo.lock to be present.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? How was it working before we had this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.gitignore only affects files that aren't tracked.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it was working because we'd generated Cargo.lock files on our local machines and that was allowing the update script to work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it was already present and tracked, modifications would be detected by git.

I discovered that this was a problem when I removed Cargo.lock through IDEA's project tree view, which runs git rm .... git then promptly ignored the newly generated lockfile, because it was no longer tracked.

Loading