Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicit any in match #4

Closed
wants to merge 1 commit into from
Closed

Fix implicit any in match #4

wants to merge 1 commit into from

Conversation

tamird
Copy link

@tamird tamird commented Jul 18, 2016

TypeScript 2.0.0 caught this; see
microsoft/TypeScript#9657 for details.

TypeScript 2.0.0 caught this; see
microsoft/TypeScript#9657 for details.
@blakeembrey
Copy link
Member

Thanks for that catch!

The flag has been a part of TypeScript as long as I've used it, so it's not 2.0-specific (in fact, it's meant to be enabled on this repo, but I'm not sure the maintainer was running it).

@blakeembrey
Copy link
Member

Could you port andrew-w-ross@0ab06bd instead?

@tamird
Copy link
Author

tamird commented Jul 18, 2016

This particular implicit any is not caught by TS pre-2.0, though.

On Jul 18, 2016 14:47, "Blake Embrey" [email protected] wrote:

Thanks for that catch!

The flag has been a part of TypeScript as long as I've used it, so it's
not 2.0-specific (in fact, it's meant to be enabled on this repo, but I'm
not sure the maintainer was running it).


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABdsPGEDbr2BN3fF5imSfkk4Yv94OBE4ks5qW8oogaJpZM4JOZKM
.

@blakeembrey
Copy link
Member

Ah, good catch. I could have sworn I'd seen it caught before, thanks.

@tamird
Copy link
Author

tamird commented Jul 18, 2016

You can just cherry pick that directly and close this PR.

On Jul 18, 2016 14:47, "Blake Embrey" [email protected] wrote:

Could you port andrew-w-ross/typings-react-router@0ab06bd
andrew-w-ross@0ab06bd
instead?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABdsPDTQ1H--VS1Q6KVl5ddZIY7o3TVBks5qW8pZgaJpZM4JOZKM
.

@blakeembrey
Copy link
Member

Done: fd6b82d.

@tamird tamird deleted the patch-1 branch July 19, 2016 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants