Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Imports, remove JS/TS config #677

Merged
merged 25 commits into from
Jan 18, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add launch task without TS
machty committed Jan 14, 2024
commit 3589b20a5b5f6014cc05bca325933c8453e61a3f
20 changes: 19 additions & 1 deletion .vscode/launch.json
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
"version": "0.2.0",
"configurations": [
{
"name": "Debug Extension",
"name": "Debug Extension (TS LSP Enabled)",
"type": "extensionHost",
"request": "launch",
"preLaunchTask": "npm: build",
@@ -16,6 +16,24 @@
"--extensionDevelopmentPath=${workspaceFolder}/packages/vscode",
"${workspaceFolder}/test-packages"
]
},
{
"name": "Debug Extension (TS LSP Disabled)",
"type": "extensionHost",
"request": "launch",
"preLaunchTask": "npm: build",
"autoAttachChildProcesses": true,
"runtimeExecutable": "${execPath}",
"outFiles": [
"${workspaceFolder}/**/*.js",
"!**/node_modules/**"
],
"args": [
"--extensionDevelopmentPath=${workspaceFolder}/packages/vscode",
"--disable-extension",
"vscode.typescript-language-features",
"${workspaceFolder}/test-packages"
]
}
]
}
2 changes: 1 addition & 1 deletion packages/core/src/language-server/glint-language-server.ts
Original file line number Diff line number Diff line change
@@ -229,7 +229,7 @@ export default class GlintLanguageServer {
kind: scriptElementKindToCompletionItemKind(this.ts, completionEntry.kind),

labelDetails: {
// This displays the module specific for auto-imports, e.g. "../../component" or "@glimmer/component"
// This displays the module specifier for auto-imports, e.g. "../../component" or "@glimmer/component"
description: completionEntry.data?.moduleSpecifier,
},