Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash for operations on an unaffiliated template #131

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

dfreeman
Copy link
Member

@dfreeman dfreeman commented Apr 2, 2021

If we ever try to look up the translated TS code for a particular location and find ourselves still looking at a template, it means we didn't know what to do with that .hbs file and asking TypeScript about it will lead to a bad time. This change guards against that scenario.

This should fix #124.

@dfreeman dfreeman added the bug Something isn't working label Apr 2, 2021
@dfreeman dfreeman merged commit 7068e8b into master Apr 2, 2021
@dfreeman dfreeman deleted the loose-templates-crash branch April 2, 2021 16:23
@dfreeman dfreeman mentioned this pull request Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in VSCode output pane when trying to get autocompletions
1 participant