Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overeager query invalidation, optimize validation, bump gradle version #29

Merged
merged 1 commit into from
May 4, 2024

Conversation

ty1824
Copy link
Owner

@ty1824 ty1824 commented May 4, 2024

Resolves several bugs:

  • Queries assigned a value equal to their already-computed value would invalidate their dependencies
  • Queries with transitive dependencies whose inputs had maybe changed would never validate (and thus always recompute).
  • Added tests for these cases and several others.

Some enhancements:

  • Eliminated a lot of dead code around input value verification (likely added to ensure correct behavior in the presence of the above bugs)
  • Reduced the toString length of various query internals to make debugging easier.

Copy link

github-actions bot commented May 4, 2024

Coverage Results

File Coverage [100.00%]
inkt/src/main/kotlin/dev/dialector/inkt/next/QueryDatabaseImpl.kt 100.00%
inkt/src/main/kotlin/dev/dialector/inkt/next/QueryDslImpl.kt 100.00%
Total Project Coverage 93.16%

@ty1824 ty1824 merged commit 5a7fd58 into main May 4, 2024
2 checks passed
@ty1824 ty1824 deleted the fix/inkt-overeager-invalidation branch May 4, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant