Skip to content

Commit

Permalink
Remove dep from sui-core to sui-test-cluster (MystenLabs#18539)
Browse files Browse the repository at this point in the history
## Description 

depending on sui-test-cluster means depending on everything. sui-core
should not depend on it.
Move the impacted test to e2e tests.

## Test plan 

CI

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
  • Loading branch information
lxfind authored and tx-tomcat committed Jul 29, 2024
1 parent 006366f commit aababf9
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 6 deletions.
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion crates/sui-core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ serde-reflection.workspace = true
serde_yaml.workspace = true
num-bigint = "0.4.4"

test-cluster.workspace = true
move-symbol-pool.workspace = true

sui-test-transaction-builder.workspace = true
Expand Down
4 changes: 0 additions & 4 deletions crates/sui-core/src/overload_monitor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ use tokio::time::sleep;
use tracing::{debug, info};
use twox_hash::XxHash64;

#[cfg(test)]
#[path = "unit_tests/overload_monitor_tests.rs"]
pub mod overload_monitor_tests;

#[derive(Default)]
pub struct AuthorityOverloadInfo {
/// Whether the authority is overloaded.
Expand Down

0 comments on commit aababf9

Please sign in to comment.