Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FUM-3033-rule-priorities #5

Merged
merged 2 commits into from
Mar 18, 2024
Merged

FUM-3033-rule-priorities #5

merged 2 commits into from
Mar 18, 2024

Conversation

DCamma
Copy link
Contributor

@DCamma DCamma commented Mar 18, 2024 •
edited
Loading

New priorities:

# 0: limit_search_requests_by_countries
# 1-9: block_uri_path_string
# 10-19: block_articles
# 20-29: block_regex_pattern
# 30-39 free
# 40: whitelisted_ips_v4
# 41: whitelisted_ips_v6
# 42: Rate_limit_everything_apart_from_CH
# 43: count_requests_from_ch
# 44-49: free
# 50-59: AWS Managed rule groups (these are the one that only counts and labels requests
# 60-69: AWS managed rule labels rate limit
# 70-79: country_rates
# 80: everybody_else_limit

@DCamma DCamma force-pushed the FUM-3033-rule-priorities branch from 4f703e6 to 279d153 Compare March 18, 2024 09:25
AlfGot
AlfGot reviewed Mar 18, 2024
View reviewed changes
waf.tf Outdated Show resolved Hide resolved
AlfGot
AlfGot approved these changes Mar 18, 2024
View reviewed changes
Copy link

@AlfGot AlfGot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small fix in the rules description

@DCamma DCamma force-pushed the FUM-3033-rule-priorities branch from e759362 to f285857 Compare March 18, 2024 12:22
@DCamma DCamma force-pushed the FUM-3033-rule-priorities branch from f285857 to 83850f8 Compare March 18, 2024 12:22
@DCamma DCamma merged commit 28a101a into main Mar 18, 2024
4 checks passed
@DCamma DCamma deleted the FUM-3033-rule-priorities branch March 18, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlfGot AlfGot AlfGot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DCamma @AlfGot