Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get sso admin role into the platform itself using data aws_iam_roles #21

Merged
merged 3 commits into from
Apr 26, 2024
Merged

feat: get sso admin role into the platform itself using data aws_iam_roles #21

merged 3 commits into from
Apr 26, 2024

Conversation

sgametrio
Copy link
Contributor

One less variable to pass from the caller

@sgametrio sgametrio mentioned this pull request Apr 26, 2024
Merged
@sgametrio sgametrio changed the title feat: include sso admin role into the platform itself feat: get sso admin role into the platform itself using data aws_iam_roles Apr 26, 2024
swibrow
swibrow approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@swibrow swibrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just make sure the linting passes

main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
@sgametrio sgametrio merged commit bd533b7 into main Apr 26, 2024
5 checks passed
@sgametrio sgametrio deleted the refactor-admin-access branch April 26, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swibrow swibrow swibrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgametrio @swibrow