Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ALB to read secrets and fix external DNS conflicts #19

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Allow ALB to read secrets and fix external DNS conflicts #19

merged 4 commits into from
Apr 24, 2024

Conversation

sgametrio
Copy link
Contributor

@sgametrio sgametrio commented Apr 23, 2024 •
edited
Loading

  1. Allow ALB to read secrets (for Okta auth integration)
  2. Avoid external DNS conflicts in multiple clusters

@sgametrio sgametrio changed the title enable alb to read secrets Allow ALB to read secrets and fix external DNS conflicts Apr 24, 2024
swibrow
swibrow approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@swibrow swibrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but I would use the cluster name for the txt id

addons.tf Outdated Show resolved Hide resolved
@sgametrio sgametrio merged commit a1ca329 into main Apr 24, 2024
5 checks passed
@sgametrio sgametrio deleted the FUM-3102-alb-controller-read-secrets branch April 24, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swibrow swibrow swibrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgametrio @swibrow