Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: artifact support pattern and merge_multiple #139

Merged
merged 8 commits into from
Oct 24, 2024

Conversation

DCamma
Copy link
Contributor

@DCamma DCamma commented Oct 22, 2024

Description

Add support for artifact features described here https://github.com/actions/download-artifact/tree/fa0a91b85d4f404e444e00e005971372dc801d16/?tab=readme-ov-file#inputs
Introduced inputs are pattern and merge_multiple

Motivation and Context

Requirements in case multiple artifacts needs to be pushed at different steps of the pipeline

Breaking Changes

No

How Has This Been Tested?

  • I have executed pre-commit run -a on my pull request
  • I have executed make gen_docs_run on my pull request

Copy link

github-actions bot commented Oct 22, 2024

Terraform plan for sandbox

Changes to Outputs.
Changes to Outputs:
+   file = <<-EOT
        |------------------|
        | I am an artifact |
        |------------------|
    EOT

You can apply this plan to save these new output values to the Terraform
state, without changing any real infrastructure.

📝 Plan generated in .github/workflows/_test-tf.yaml #218

Copy link

github-actions bot commented Oct 22, 2024

Terraform plan in tests/terraform/s3
With backend config: bucket=tf-state-911453050078 key=sandbox1.tfstate workspace_key_prefix=github-workflows
With var files: tests/terraform/s3/environment/sandbox.tfvars

Plan: 2 to add, 0 to change, 0 to destroy. Changes to Outputs.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create

Terraform will perform the following actions:

  # random_id.this will be created
+   resource "random_id" "this" {
+       b64_std     = (known after apply)
+       b64_url     = (known after apply)
+       byte_length = 4
+       dec         = (known after apply)
+       hex         = (known after apply)
+       id          = (known after apply)
    }

  # random_pet.this will be created
+   resource "random_pet" "this" {
+       id        = (known after apply)
+       length    = 2
+       separator = "-"
    }

Plan: 2 to add, 0 to change, 0 to destroy.

Changes to Outputs:
+   random_id  = (known after apply)
+   random_pet = (known after apply)

📝 Plan generated in .github/workflows/_test-tf.yaml #218

@DCamma DCamma changed the title Artifact support pattern and merge_multiple feat: artifact support pattern and merge_multiple Oct 22, 2024
Copy link

github-actions bot commented Oct 23, 2024

Terraform plan for sandbox

Plan: 2 to add, 0 to change, 0 to destroy. Changes to Outputs.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create

Terraform will perform the following actions:

  # random_id.this will be created
+   resource "random_id" "this" {
+       b64_std     = (known after apply)
+       b64_url     = (known after apply)
+       byte_length = 4
+       dec         = (known after apply)
+       hex         = (known after apply)
+       id          = (known after apply)
    }

  # random_pet.this will be created
+   resource "random_pet" "this" {
+       id        = (known after apply)
+       length    = 2
+       separator = "-"
    }

Plan: 2 to add, 0 to change, 0 to destroy.

Changes to Outputs:
+   random_id  = (known after apply)
+   random_pet = (known after apply)

📝 Plan generated in .github/workflows/_test-tf.yaml #218

Copy link
Contributor

@swibrow swibrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rerun the docs script so the default value is correct

@DCamma DCamma merged commit 5fb7e98 into main Oct 24, 2024
17 checks passed
@DCamma DCamma deleted the artifact-support-pattern branch October 24, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants