feat: add workflow that builds Docker and push to ECR without using artifacts #11

sgametrio · 2024-01-04T17:58:40Z

It's faster

swibrow

Looks good

I would make push an input and make it default true.

  docker_push:
    description: "Push Image to ECR"
    type: boolean
    required: false
    default: true

swibrow · 2024-01-10T15:59:19Z

.github/workflows/docker-build-push-ecr.yaml

+          push: true
+          tags: |
+            ${{ env.REGISTRY }}/${{ env.REPOSITORY }}:${{ env.IMAGE_TAG }}
+            ${{ env.REGISTRY }}/${{ env.REPOSITORY }}:latest


I would add a condition here to be master or main or feature branches will push to latest.
Also add the git sha, should always be a tag on an image

@swibrow I agree with this. I was running into errors though if I was specifying twice the SHA (because IMAGE_TAG was also assuming the git.sha value). That's why I removed it. Should I make a condition? but then not sure how to parametrize the tags parameter dynamically of the custom action...

tags: |
${{ env.REGISTRY }}/${{ env.REPOSITORY }}:${{ github.sha }}
${{ env.IMAGE_TAG != github.sha && format('{0}/{1}:{2}', env.REGISTRY, env.REPOSITORY, env.IMAGE_TAG) }}

something like that (not tested) or just use standard docker commands since running the same tag command wont error.

Also if you want to use the docker action, theres also a tag extractor
https://docs.docker.com/build/ci/github-actions/manage-tags-labels/

swibrow · 2024-01-10T16:05:19Z

.github/workflows/tf-deploy-basic.yaml

@@ -173,6 +172,11 @@ jobs:
        run: |
          echo "$SUMMARY" >> $GITHUB_STEP_SUMMARY

+      # Added this step because otherwise the UI shows a green checkmark


Could this be added to the step above?

I would remove the comment

@swibrow

We want to create anyway the summary, so we can't exit before that.

We don't want to exit at the summary step or this would be misleading because it would look like the summary step failed while it was the plan one that failed.

What do you think? I think like this is the cleanest I could think of.

This reverts commit 9d1ab1f.

…urt) and merge multiple ones

swibrow · 2024-01-11T15:12:50Z

.github/workflows/docker-build-push-ecr.yaml

+          push: true
+          tags: |
+            ${{ env.REGISTRY }}/${{ env.REPOSITORY }}:${{ env.IMAGE_TAG }}
+            ${{ env.REGISTRY }}/${{ env.REPOSITORY }}:latest


tags: |
${{ env.REGISTRY }}/${{ env.REPOSITORY }}:${{ github.sha }}
${{ env.IMAGE_TAG != github.sha && format('{0}/{1}:{2}', env.REGISTRY, env.REPOSITORY, env.IMAGE_TAG) }}

something like that (not tested) or just use standard docker commands since running the same tag command wont error.

Also if you want to use the docker action, theres also a tag extractor
https://docs.docker.com/build/ci/github-actions/manage-tags-labels/

swibrow · 2024-01-11T15:14:51Z

.github/workflows/tf-deploy-basic.yaml

@@ -173,8 +181,12 @@ jobs:
        run: |
          echo "$SUMMARY" >> $GITHUB_STEP_SUMMARY

+      - name: Exit if `terraform plan` failed


Not needed anymore. since it wont make it this far

swibrow · 2024-01-11T15:15:00Z

.github/workflows/tf-deploy-basic.yaml

+            exit 1
+          else
+            exit 0
+          fi
        continue-on-error: true


Ah this should be removed I guess

swibrow · 2024-01-11T15:15:31Z

.github/workflows/tf-deploy-basic.yaml

      - name: Terraform Apply
-        if: (github.ref_name == github.event.repository.default_branch && github.event_name == 'push' && steps.plan.outputs.exitcode == '2') || inputs.tf_deploy_override == true


You want this actually since you only want to run an apply when theres changes.

sgametrio added 8 commits January 4, 2024 18:58

feat: add workflow

2b3b5e1

fix for replacing env variables?

27600ac

fix?

76274d1

remove one tag

3f8cd57

chore: when planning it's not a deployment

912f8e9

fix: exit if terraform plan failed

15d50c0

fix: exit if terraform plan failed

c9c0678

remove unnecessary brackets

700b3ef

sgametrio changed the title ~~feat: add workflow~~ feat: add workflow that builds Docker and push to ECR without using artifacts Jan 5, 2024

swibrow requested changes Jan 10, 2024

View reviewed changes

sgametrio added 9 commits January 10, 2024 17:51

feat: optional push to ecr

3bcda29

fix: tf-deploy-basic mark as passed when plan exitcode == 2

80abf6b

fix: actions/runner#2238

ed391b1

fix: actions/runner#2238

9d1ab1f

chore: remove name

9ebea7c

Revert "fix: actions/runner#2238"

c9c0b03

This reverts commit 9d1ab1f.

remove quote

fcc0fd3

download artifacts anyway (even if 0 artifacts are present, doesn't h…

2e38399

…urt) and merge multiple ones

remove merge multiple

808eb32

swibrow reviewed Jan 11, 2024

View reviewed changes

sgametrio added 5 commits January 11, 2024 16:31

always tag with the github sha

7542dc1

fix: don't pass image-tag as default as github sha

fb99443

test docker build push ecr

ccf4591

test

4916f5c

remove push

111b887

sgametrio closed this Jan 11, 2024

rbapst-tamedia deleted the include-build-and-push-no-artifacts branch January 10, 2025 11:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add workflow that builds Docker and push to ECR without using artifacts #11

feat: add workflow that builds Docker and push to ECR without using artifacts #11

sgametrio commented Jan 4, 2024 •

edited

Loading

swibrow left a comment

swibrow Jan 10, 2024

sgametrio Jan 10, 2024

swibrow Jan 11, 2024

swibrow Jan 10, 2024

sgametrio Jan 10, 2024 •

edited

Loading

swibrow Jan 11, 2024

swibrow Jan 11, 2024

swibrow Jan 11, 2024

swibrow Jan 11, 2024

		- name: Terraform Apply
		if: (github.ref_name == github.event.repository.default_branch && github.event_name == 'push' && steps.plan.outputs.exitcode == '2') \|\| inputs.tf_deploy_override == true

feat: add workflow that builds Docker and push to ECR without using artifacts #11

feat: add workflow that builds Docker and push to ECR without using artifacts #11

Conversation

sgametrio commented Jan 4, 2024 • edited Loading

swibrow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sgametrio Jan 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sgametrio commented Jan 4, 2024 •

edited

Loading

sgametrio Jan 10, 2024 •

edited

Loading